Re: [PATCH] grub-install: Improve support for partitioned loop devices.

[Andrey Borzenkov]

В Sat, 25 Jan 2014 20:41:00 -0500
Mike Gilbert <address@hidden> пишет:

> * grub-core/osdep/linux/getroot.c (grub_util_part_to_disk): Detect
> /dev/loopX as being the parent of /dev/loopXpY.

Those devices are normally device-mapper ones (created by kpartx) and
grub already detects parent by following device-mapper tree. What
exact problem are you trying to solve?

> ---
>  ChangeLog                       |  5 +++++
>  grub-core/osdep/linux/getroot.c | 13 +++++++++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/ChangeLog b/ChangeLog
> index c93f11f..d5c5c3c 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2014-01-26  Mike Gilbert <address@hidden>
> +     grub-install: Improve support for partitioned loop devices.
> +
> +     * grub-core/osdep/linux/getroot.c (grub_util_part_to_disk): Detect
> +     /dev/loopX as being the parent of /dev/loopXpY.
>  
>  2014-01-25  Andrey Borzenkov <address@hidden>
>  
> diff --git a/grub-core/osdep/linux/getroot.c b/grub-core/osdep/linux/getroot.c
> index 772de0a..19581d3 100644
> --- a/grub-core/osdep/linux/getroot.c
> +++ b/grub-core/osdep/linux/getroot.c
> @@ -883,6 +883,19 @@ grub_util_part_to_disk (const char *os_dev, struct stat 
> *st,
>         *pp = '\0';
>         return path;
>       }
> +
> +      /* If this is a loop device */
> +      if ((strncmp ("loop", p, 4) == 0) && p[4] >= '0' && p[4] <= '9')
> +     {
> +       char *pp = p + 4;
> +       while (*pp >= '0' && *pp <= '9')
> +         pp++;
> +       if (*pp == 'p')
> +         *is_part = 1;
> +       /* /dev/loop[0-9]+p[0-9]* */
> +       *pp = '\0';
> +       return path;
> +     }
>      }
>  
>    return path;