[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES |
|
Date: |
Sat, 18 Jan 2014 19:08:35 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.2.0 |
On 18.01.2014 18:12, Andrey Borzenkov wrote:
> В Sat, 18 Jan 2014 17:55:38 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
>
>> On 18.01.2014 17:27, Andrey Borzenkov wrote:
>>> While on it, pass detected
>>> nm arguments instead of hardcoding them.
>> please make this part a separate patch.
>
> is it OK to commit without this part?
>
could you send the remaining part alone? It's difficult to see throught
intermingled patch.
>> This would indicate that you
>> support non-portable nm output which in this branch isn't the case. Why
>> do you need it in the first place?
>>
>
> I do not need it for MinGW case; but it just looks incorrect in general
> case - first we check nm arguments and then ignore it.
Because relevant support in scripts isn't available yet.
> I agree that
> mixing two patches was wrong on my side.
>
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
signature.asc
Description: OpenPGP digital signature