grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES


From: Andrey Borzenkov
Subject: Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES
Date: Sat, 18 Jan 2014 21:12:02 +0400

В Sat, 18 Jan 2014 17:55:38 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:

> On 18.01.2014 17:27, Andrey Borzenkov wrote:
> >  While on it, pass detected
> > nm arguments instead of hardcoding them.
> please make this part a separate patch.

is it OK to commit without this part?

> This would indicate that you
> support non-portable nm output which in this branch isn't the case. Why
> do you need it in the first place?
> 

I do not need it for MinGW case; but it just looks incorrect in general
case - first we check nm arguments and then ignore it. I agree that
mixing two patches was wrong on my side.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]