[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] mkimage: support images which require full relocation at
From: |
Andrey Borzenkov |
Subject: |
Re: [PATCH 6/7] mkimage: support images which require full relocation at mkimage time. |
Date: |
Mon, 30 Dec 2013 19:46:43 +0400 |
В Вс, 29/12/2013 в 18:47 +0000, Ian Campbell пишет:
> @@ -1530,9 +1551,9 @@ SUFFIX (load_image) (const char *kernel_path, size_t
> *exec_size,
> for (i = 0; i < num_sections; i++)
> section_vaddresses[i] = section_addresses[i] +
> image_target->vaddr_offset;
>
> - if (!grub_image_needs_reloc(image_target))
> + if (!grub_image_needs_reloc(image_target) ||
> grub_image_needs_abs_reloc(image_target))
> {
grub_image_needs_reloc implies grub_image_need_abs_reloc. Looks like one
of hunks should be dropped?
> @@ -922,11 +923,16 @@ grub_arm_reloc_jump24 (grub_uint32_t *target,
> Elf32_Addr sym_addr)
> static int grub_image_needs_reloc(const struct
> grub_install_image_target_desc *target)
> {
> if (target->id == IMAGE_EFI)
> return 1;
> - return 0;
> + return grub_image_needs_abs_reloc(target);
> }
>
- [PATCH 0/7] arm-uboot: support for different RAM bases, Ian Campbell, 2013/12/29
- [PATCH 2/7] mkimage: Replace hardcoded 0x400 in R_ARM_ABS32 relocation, Ian Campbell, 2013/12/29
- [PATCH 1/7] mkimage: Refactor IMAGE_EFI checks into a function grub_image_needs_reloc., Ian Campbell, 2013/12/29
- [PATCH 3/7] mkimage: account for space for trampolines earlier, Ian Campbell, 2013/12/29
- [PATCH 4/7] mkimage: make R_ARM_ABS32 debug output more consistent, Ian Campbell, 2013/12/29
- [PATCH 5/7] mkimage: allow linking at address 0, Ian Campbell, 2013/12/29
- [PATCH 6/7] mkimage: support images which require full relocation at mkimage time., Ian Campbell, 2013/12/29
- [PATCH 7/7] arm-uboot: support relocation at installation time, Ian Campbell, 2013/12/29
- Re: [PATCH 0/7] arm-uboot: support for different RAM bases, Ian Campbell, 2013/12/29
- Re: [PATCH 0/7] arm-uboot: support for different RAM bases, Leif Lindholm, 2013/12/29
- Re: [PATCH 0/7] arm-uboot: support for different RAM bases, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/29