grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/7] mkimage: support images which require full relocation at


From: Andrey Borzenkov
Subject: Re: [PATCH 6/7] mkimage: support images which require full relocation at mkimage time.
Date: Mon, 30 Dec 2013 19:46:43 +0400

В Вс, 29/12/2013 в 18:47 +0000, Ian Campbell пишет:
> @@ -1530,9 +1551,9 @@ SUFFIX (load_image) (const char *kernel_path, size_t 
> *exec_size,
>    for (i = 0; i < num_sections; i++)
>      section_vaddresses[i] = section_addresses[i] + 
> image_target->vaddr_offset;
>  
> -  if (!grub_image_needs_reloc(image_target))
> +  if (!grub_image_needs_reloc(image_target) || 
> grub_image_needs_abs_reloc(image_target))
>      {

grub_image_needs_reloc implies grub_image_need_abs_reloc. Looks like one
of hunks should be dropped?

> @@ -922,11 +923,16 @@ grub_arm_reloc_jump24 (grub_uint32_t *target, 
> Elf32_Addr sym_addr)
>  static int grub_image_needs_reloc(const struct 
> grub_install_image_target_desc *target)
>  {
>    if (target->id == IMAGE_EFI)
>      return 1;
> -  return 0;
> +  return grub_image_needs_abs_reloc(target);
>  }
>  





reply via email to

[Prev in Thread] Current Thread [Next in Thread]