[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile) |
|
Date: |
Fri, 27 Dec 2013 20:34:01 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 |
On 27.12.2013 19:25, Andrey Borzenkov wrote:
> В Чт, 26/12/2013 в 23:54 +0400, Andrey Borzenkov пишет:
>> I'm not sure how to fix it. It is pulled in by build-grub-pep2elf and
>> build-grub-pe2elf. Those are build time programs and so use
>> BUILD_CPPFLAGS; adding CPPFLAGS_GNULIB is probably not appropriate. It
>> compiles just fine with error.h commented out. May be something like
>>
>> #if !defined(GRUB_BUILD) || defined(HAVE_ERROR_H)
>>
>
> On the second glance - why is <error.h> needed at all? Nothing defined
> there is used in misc.c and on Linux it compiles just fine with error.h
> as well.
>
> May be we could simply drop it?
>
Yes. I was going to answer with this. Many of includes are inherited by
copying of include parts.
error.h there can simply be removed
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
signature.asc
Description: OpenPGP digital signature