Re: Request a freeze exception for vlantag feature

[pfsmorigo]

Mon, Dec 23, 2013 at 09:02:57PM +0400, Andrey Borzenkov wrote:
> В Пн, 23/12/2013 в 11:34 -0500, Paulo Flabiano Smorigo/Brazil/IBM пишет:
> > Hello everyone,
> > 
> > With the consent of Vladimir Serbinenko, I committed three patches in  
> > the next branch. Those patches add support for virtual LAN (VLAN)  
> > tagging. VLAN tagging allows multiple VLANs in a bridged network to  
> > share the same physical network link but maintain isolation:
> > 
> > http://en.wikipedia.org/wiki/IEEE_802.1Q
> > 
> > http://git.savannah.gnu.org/gitweb/?p=grub.git;a=commit;h=11454e94ea8e78317b9c9ab22855e26890880745
> > http://git.savannah.gnu.org/gitweb/?p=grub.git;a=commit;h=8ff3c31f6d59ca758b3bc0020e5140dcc937edd6
> > http://git.savannah.gnu.org/gitweb/?p=grub.git;a=commit;h=af768f8d4166aae41bbac8575fca7c65a319bfdb
> > 
> > 
> 
> VLAN tag is 12 bits, with 4 remaining bits being packet priority. You
> need to mask them off before comparing. 
> 

Tks for the feedback. I fixed it. Can you take a look?

http://git.io/ol5y-Q

> A couple of words in documentation would be nice (are those variables
> for this platform documented at all?)

Ok, I'll will add a documentation.


Btw, I need to add it to the commands. I'm not sure if I add a parameter
to net_add_addr and net_bootp or create a new one to set it.

> 
> > I come here to ask for an freeze exception so it can be also in master  
> > and in 2.02 release.
> >
> > Thanks in advance,
> > --
> > Paulo Flabiano Smorigo
> > Software Engineer
> > Linux Technology Center - IBM Systems & Technology Group
> > 
> > 
> > _______________________________________________
> > Grub-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> 
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel

-- 
--
Paulo Flabiano Smorigo
IBM Linux Technology Center