[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] add fdt prerequisites for arm64 UEFI Linux loader
|
From: |
Leif Lindholm |
|
Subject: |
Re: [PATCH] add fdt prerequisites for arm64 UEFI Linux loader |
|
Date: |
Wed, 18 Dec 2013 16:56:11 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Dec 16, 2013 at 10:17:12PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> > + et->empty_node.node_end = grub_cpu_to_be32 (FDT_END);
> > + et->empty_node.prop_end = grub_cpu_to_be32 (FDT_END_NODE);
>
> grub_cpu_to_be32_compile_time is better suited.
Ok, will change.
> > +#define grub_fdt_set_prop64(fdt, nodeoffset, name, val) \
> > +({ \
> > + grub_uint64_t _val = grub_cpu_to_be64(val); \
> > + grub_fdt_set_prop ((fdt), (nodeoffset), (name), &_val, 8); \
> > +})
> > +
>
> Why not make it into inline function?
No particular reason, it is effectively a clone of
grub_fdt_set_prop32() above it.
/
Leif