[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] Accept environment variables on the command line for Xen
From: |
Colin Watson |
Subject: |
Re: [PATCH 2/4] Accept environment variables on the command line for Xen. |
Date: |
Thu, 12 Dec 2013 16:11:59 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 12, 2013 at 07:48:05PM +0400, Andrey Borzenkov wrote:
> > + Accept environment variables on the command line for Xen.
>
> Thank you!
>
> It may make sense to generalize it to other archs. At least EFI
> definitely comes in mind. In this case platform specific part is only
> to fetch parameter string(s). What about
>
> - move fetch_command_line_word and parse_command_line to separate file
> that is included for specific platforms only
> - make each platform that can accept fetch parameters in platform
> specific way and call common code (parse_command_line)
>
> Does it make sense?
That might well be sensible, yes (multiboot too IIRC), but I was
concerned about generalising this too early since some ports already
have specialised requirements for command-line parsing - e.g. I think
mipsel-loongson has some oddities. Maybe it would be best to do that
kind of thing as a follow-up patch series?
--
Colin Watson address@hidden
- [PATCH 1/4] Add an option to exclude devices from search results., (continued)
- [PATCH 1/4] Add an option to exclude devices from search results., Colin Watson, 2013/12/12
- Re: [Xen-devel] [PATCH 1/4] Add an option to exclude devices from search results., Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/13
- Re: [Xen-devel] [PATCH 1/4] Add an option to exclude devices from search results., Colin Watson, 2013/12/13
- [PATCH] add --boot-directory option to grub-mkstandalone, Andrey Borzenkov, 2013/12/13
- Re: [PATCH] add --boot-directory option to grub-mkstandalone, Colin Watson, 2013/12/20
- Re: [PATCH] add --boot-directory option to grub-mkstandalone, Andrey Borzenkov, 2013/12/21
- Re: [PATCH] add --boot-directory option to grub-mkstandalone, Andrey Borzenkov, 2013/12/21
- Re: [Xen-devel] [PATCH 1/4] Add an option to exclude devices from search results., Jordan Uggla, 2013/12/22
[PATCH 2/4] Accept environment variables on the command line for Xen., Colin Watson, 2013/12/12
- Re: [PATCH 2/4] Accept environment variables on the command line for Xen., Andrey Borzenkov, 2013/12/12
- Re: [PATCH 2/4] Accept environment variables on the command line for Xen., Vladimir 'phcoder' Serbinenko, 2013/12/12
- Re: [PATCH 2/4] Accept environment variables on the command line for Xen., Andrey Borzenkov, 2013/12/12
- Re: [PATCH 2/4] Accept environment variables on the command line for Xen., Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/12
- Re: [PATCH 2/4] Accept environment variables on the command line for Xen., Colin Watson, 2013/12/12
- Re: [PATCH 2/4] Accept environment variables on the command line for Xen., Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/12
[PATCH 3/4] Build grub.xen., Colin Watson, 2013/12/12