grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make grub-mkconfig fail if GRUB_FS cannot be determined


From: Colin Watson
Subject: Re: [PATCH] Make grub-mkconfig fail if GRUB_FS cannot be determined
Date: Fri, 6 Dec 2013 13:12:12 +0000
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Dec 06, 2013 at 12:50:48PM +0000, Colin Watson wrote:
> Commit c0f90770b89e05730919e7d97cc9abeb84232777 caused grub-mkconfig
> to carry on anyway if "grub-probe --target=fs /" fails.  However,
> this was in 2007 when GRUB's filesystem support was much less
> complete.  Nowadays this can be expected to only fail in bad
> situations, and will almost certainly lead to the generated grub.cfg
> being useless, so it makes no sense for grub-mkconfig to succeed.

Vladimir makes the reasonable argument on IRC that this will break if
you have a / that GRUB doesn't understand but a /boot that it does,
which in general is supposed to be supported.  I withdraw this patch.

-- 
Colin Watson                                       address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]