Re: grub2 boot root-on-zfs errors

[Colin Watson]

On Fri, Nov 22, 2013 at 08:30:14AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko 
wrote:
> On 22.11.2013 08:09, Beeblebrox wrote:
> > grub-core/osdep/unix/platform.c:34:28: error: use of undeclared
> > identifier 'PATH_MAX'
> >   char *ret = xmalloc (2 * PATH_MAX);
> Please try
> diff --git a/grub-core/osdep/unix/platform.c
> b/grub-core/osdep/unix/platform.c
> index 65c93f1..a527a1c 100644
> --- a/grub-core/osdep/unix/platform.c
> +++ b/grub-core/osdep/unix/platform.c
> @@ -27,6 +27,7 @@
>  #include <dirent.h>
>  #include <string.h>
>  #include <errno.h>
> +#include <limits.h>
> 
>  static char *
>  get_ofpathname (const char *dev)
> 

This will not be sufficient to build on GNU/Hurd (get_ofpathname isn't
directly relevant to that platform, but that function will be compiled
there anyway).  We need to avoid the use of PATH_MAX entirely, per:

  https://www.gnu.org/software/hurd/hurd/porting/guidelines.html

-- 
Colin Watson                                       address@hidden