[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] grub-core/gfxmenu/widget-box.c - bugfix: incorrect drawing i
|
From: |
Andrey Borzenkov |
|
Subject: |
Re: [PATCH] grub-core/gfxmenu/widget-box.c - bugfix: incorrect drawing in cases of NULL center slice |
|
Date: |
Sat, 20 Jul 2013 18:18:04 +0400 |
В Wed, 17 Jul 2013 21:55:58 +0400
Vladimir Testov <address@hidden> пишет:
> See screenshots included.
>
> If the center slice is NULL then west or north slice is also NULL
Why? As far as I can tell code is supposed to scale all parts of
bitmap. What triggers this problem?
> so the
> height_n or width_w is also NULL. We can count these values from raw (non-
> scaled) bitmaps. The values will be the same as before for common cases. And
> the bug will be fixed.
>
This looks more like a workaround for some other problem. Also while
currently width (for W) or height (for N) does not change, it may be
reimplemented in the future. In this case this patch will create hard
to spot bug.