grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen


From: Konrad Rzeszutek Wilk
Subject: [PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen
Date: Mon, 15 Jul 2013 14:00:06 -0400
User-agent: Mutt/1.5.21 (2010-09-15)

Hey,

There is a discussion on the linux-kernel mailing list in which the
Linus states that "if you depend on any config file, you're broken
by definition" (https://lkml.org/lkml/2013/7/15/368).

The 20_linux_xen does that however it should not do it. In all fairness
this check is a bit of old as pretty much any upstream kernel
is being built by default from distros to boot with Xen. If it does
not, Xen will print a message telling the user that Linux does not
have the required components.

This patch removes said check.

Signed-off-by: Konrad Rzeszutek Wilk <address@hidden>

=== modified file 'util/grub.d/20_linux_xen.in'
--- util/grub.d/20_linux_xen.in 2013-03-24 13:03:33 +0000
+++ util/grub.d/20_linux_xen.in 2013-07-15 17:34:32 +0000
@@ -144,20 +144,8 @@
 }
 
 linux_list=`for i in /boot/vmlinu[xz]-* /vmlinu[xz]-* /boot/kernel-*; do
-    if grub_file_is_not_garbage "$i"; then
-       basename=$(basename $i)
-       version=$(echo $basename | sed -e "s,^[^0-9]*-,,g")
-       dirname=$(dirname $i)
-       config=
-       for j in "${dirname}/config-${version}" 
"${dirname}/config-${alt_version}" "/etc/kernels/kernel-config-${version}" ; do
-           if test -e "${j}" ; then
-               config="${j}"
-               break
-           fi
-       done
-        if (grep -qx "CONFIG_XEN_DOM0=y" "${config}" 2> /dev/null || grep -qx 
"CONFIG_XEN_PRIVILEGED_GUEST=y" "${config}" 2> /dev/null); then echo -n "$i " ; 
fi
-    fi
-    done`
+    if grub_file_is_not_garbage "$i"; then echo -n "$i "; fi
+           done`
 if [ "x${linux_list}" = "x" ] ; then
     exit 0
 fi




reply via email to

[Prev in Thread] Current Thread [Next in Thread]