[PATCH] [1/?] grub-core/gfxmenu/gui_list.c - troubles with heights

[Vladimir Testov]

item_padding = 20
item_height = 30
item_spacing = 20
selected_item_pixmap_style = "inbox_*.png"
menu_pixmap_style = "menu_*.png"

heights of inbox_n.png, inbox_s.png, menu_n.png, menu_s.png equal 5

height option will be mentioned for each example

a) selected item's height is item_height - 1, not item_height
(see before-list-4-up.png attached)
b) get_num_shown_items can behave incorrectly
height = 235
(see before-list-4-down.png attached)
and
height = 230
(see before-list-4-down2.png attached)
c) get_minimal_size can behave incorrectly
height = 39
(see before-list-3-down.png attached)

After applying this patch:
item's height is item_height

height = 240 - everything is O.K.
(see after-list-4-up.png and after-list-4-down.png attached)

height = 239 - not enough for 4 entries - everything is O.K.
(see after-list-239.png attached)

height =39 - everything is O.K.
(see after-list-minimal-down.png and after-list-minimal-up.png attached)

-- 
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru

before-list-4-up.png
Description: PNG image

before-list-4-down.png
Description: PNG image

before-list-4-down2.png
Description: PNG image

before-list-3-down.png
Description: PNG image

after-list-4-up.png
Description: PNG image

after-list-4-down.png
Description: PNG image

after-list-239.png
Description: PNG image

after-list-minimal-down.png
Description: PNG image

after-list-minimal-up.png
Description: PNG image

grub-list-height-fix.patch
Description: Text Data