grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix autogen.sh on "dirty" tree


From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] fix autogen.sh on "dirty" tree
Date: Tue, 16 Apr 2013 16:11:57 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12

On 10.04.2013 18:45, Andrey Borzenkov wrote:

> В Tue,  9 Apr 2013 20:20:26 +0400
> Andrey Borzenkov <address@hidden> пишет:
> 
>>  for x in mpi-asm-defs.h mpih-add1.c mpih-sub1.c mpih-mul1.c mpih-mul2.c 
>> mpih-mul3.c mpih-lshift.c mpih-rshift.c; do
>> -    if [ -f grub-core/lib/libgcrypt-grub/mpi/"$x" ]; then
>> +    if [ -h grub-core/lib/libgcrypt-grub/mpi/"$x" ]; then
>>      rm grub-core/lib/libgcrypt-grub/mpi/"$x"
>>      fi
>>      ln -s generic/"$x" grub-core/lib/libgcrypt-grub/mpi/"$x"
> 
> 
> Hmm ... they become plain files in tardist ...
> 
> What is better - check for both -f and -h or simply use cp instead of
> ln? cp looks simpler and directory is regenerated from scratch anyway.
> 

The idea behind ln is that if compilation fails on a file then when if
you modified the file reported in error your changes will be to definite
file, not to a temporary copy.

> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel



Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]