grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix menu size calculation in presence of selected item pixma


From: Vladimir Testov
Subject: Re: [PATCH] fix menu size calculation in presence of selected item pixmap
Date: Tue, 09 Apr 2013 13:08:16 +0400
User-agent: KMail/4.9.5 (Linux/3.5.0-26-generic; KDE/4.9.5; x86_64; ; )

>I don't see the logic behind this. item_top in draw_menu doesn't
>increase more on selected item than on any other one.

Current function does not take into account pixmap style of the selected item.
This pixmap style needs for additional space to be drawn. 
Overall height of the selected item is:
sel_top_pad + sel_bottom_pad + item_height - 1

So the number of shown items is miscalculated.
And in some cases we will have the bottom item not fully drawn. I can sent a screenshot.

--

With best regards,

_______________________________

Vladimir Testov, ROSA Laboratory.

www.rosalab.ru


reply via email to

[Prev in Thread] Current Thread [Next in Thread]