grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] ARM/U-Boot basic build system additions


From: Francesco Lavra
Subject: Re: [PATCH 1/7] ARM/U-Boot basic build system additions
Date: Sat, 30 Mar 2013 16:09:28 +0100
User-agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1

Hi,

On 03/24/2013 06:01 PM, Leif Lindholm wrote:
> === modified file 'conf/Makefile.common'
> --- conf/Makefile.common      2013-03-03 14:57:30 +0000
> +++ conf/Makefile.common      2013-03-24 11:00:29 +0000
> @@ -37,6 +37,13 @@
>    CFLAGS_PLATFORM += -mno-app-regs
>    LDFLAGS_PLATFORM = -Wl,-melf64_sparc -mno-relax
>  endif
> +if COND_arm
> +# Image entry point always in ARM (A32) state - ensure proper functionality 
> if
> +# the rest is built for the Thumb (T32) state.
> +  CFLAGS_PLATFORM += -mthumb-interwork -mno-unaligned-access -mlong-calls
> +  CCASFLAGS_PLATFORM = -Wa,-mimplicit-it=thumb

The -mimplicit-it=thumb assembler option is generally frowned upon and
is used mostly to convert existing pieces of code from ARM to Thumb
encoding.
Since you are writing new code, it's better to avoid this option and
manually insert IT instructions in the assembly where appropriate.

> +  LDFLAGS_PLATFORM = -Wl,--wrap=__clear_cache
> +endif
>  
>  # Other options
>  

--Francesco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]