Re: [PATCH] gfxterm: check elements' properties and hadle errors.

[Vladimir Testov]

>This loses original OOM error if it was returned. May be make it return

>true/false and check if grub_errno is set on false. Not sure.

>

>Do you have any real problem to solve? I wonder if these errors are

>visible to user at all; if not, setting them does not really buy

>anything.

The original error is not beeing processed at all in the current state.

So if we have error in global option or in component's name - the error is displayed.

But if we have error in component's option - (in current state) nothing is displayed and the option is just beeing ignored.

With this patch the error will be displayed in all cases.

 

Andrey, maybe you should try to compile GRUB with the patch or read source code more carefully before making conclusions? Or should I sent you screenshot with displaying of the error? Or you just don't know how the theme file is beeing parsed?

 

Please, try to be more concrete. :)

 

--

With best regards,

_______________________________

Vladimir Testov, ROSA Laboratory.

www.rosalab.ru