grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] fix memory leak in grub_efidisk_get_device_name()


From: Andrey Borzenkov
Subject: [PATCH] fix memory leak in grub_efidisk_get_device_name()
Date: Wed, 30 Jan 2013 15:04:21 +0400

Free dup_dp also in case get_diskname_from_path() fails.

Signed-off-by: Andrey Borzenkov <address@hidden>

---
 ChangeLog                    |    5 +++++
 grub-core/disk/efi/efidisk.c |    5 ++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index e5b71cf..a73d694 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-01-27  Andrey Borzenkov <address@hidden>
+
+       * grub-core/disk/efi/efidisk.c(grub_efidisk_get_device_name): Fix
+       memory leak if device name is not found.
+
 2013-01-30  Vladimir Serbinenko  <address@hidden>
 
        * grub-core/fs/xfs.c (grub_xfs_read_block): Fix computation in presence
diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidisk.c
index 98cd226..19c5923 100644
--- a/grub-core/disk/efi/efidisk.c
+++ b/grub-core/disk/efi/efidisk.c
@@ -797,7 +797,10 @@ grub_efidisk_get_device_name (grub_efi_handle_t *handle)
       dup_ldp->length[1] = 0;
 
       if (!get_diskname_from_path (dup_dp, device_name))
-       return 0;
+       {
+         grub_free (dup_dp);
+         return 0;
+       }
       parent = grub_disk_open (device_name);
       grub_free (dup_dp);
 
-- 
tg: (4b9ea2e..) u/efi-dup_dp (depends on: master)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]