grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Removing nested functions, part one of lots


From: Colin Watson
Subject: Re: [PATCH] Removing nested functions, part one of lots
Date: Wed, 2 Jan 2013 00:05:04 +0000
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Jan 02, 2013 at 01:37:38AM +0400, Andrey Borzenkov wrote:
> В Tue, 1 Jan 2013 14:42:04 +0000
> Colin Watson <address@hidden> пишет:
> >  * If a hook requires more than one local variable from its parent
> >    function, declare "struct <name-of-parent>_ctx" with the necessary
> >    variables, and convert both the hook and the parent to access the
> >    variables in question via that structure.
> 
> Personally I find "ctx" part a bit confusing. It is not really execution
> context in usual sense, it is just collection of random variables. I
> would rather go with "struct <name-of-parent>_data" here.

I'm fine with that (and this is exactly why I posted this for a bit of a
bikeshedding opportunity :-) ).  Vladimir, any opinions on the naming?

-- 
Colin Watson                                       address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]