Re: [bug #36532] boot in EFI mode (x86_64) fails on some systems

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 24.05.2012 19:27, address@hidden wrote:

> Hello…
> 
>  
> 
> I just submitted a grub2 bug, along with a patch, at
> <http://savannah.gnu.org/bugs/?36532>.
> 
>  
> 
> Is that the right place for a patch, or should I sent it to this mailing
> list?

This patch is for 1.99. Could you update it to 2.00~beta5 and post here
inline? Also problematic are:
- Huge copy-paste for determining load address. It should be something
like having a function for allocation of initrd-like chunk.
- No need to probe for mmap size if we don't use the size. It's
extremely unlikely that this call fails for any reason other than small
buffer.
- You allocate the exact size of mmap. This is wrong as allocating may
increase the size of mmap slightly. You need to allocate at least 4K more.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature