grub-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add support for entering the firmware setup screen.

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] Add support for entering the firmware setup screen.
Date: Thu, 24 May 2012 17:40:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4 
On 24.05.2012 16:31, Peter Jones wrote:

> +  if (old_os_indications != NULL && oi_size == 8)
> +    os_indications |= *old_os_indications;
> +

Could you make this 8 a sizeof ? Other than that the patch is good and
is approved post-2.0

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to
[Prev in Thread] Current Thread [Next in Thread]