Re: [PATCH] bug fix for bootp

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 29.04.2012 20:59, Bean wrote:
> 2012/4/30 Bean <address@hidden>:
>> 2012/4/30 Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden>:
>>> On 29.04.2012 20:26, Bean wrote:
>>>> Hi,
>>>>
>>>> It should be ok, since it's inside    FOR_NET_NETWORK_LEVEL_INTERFACES
>>>> (inf) loop and compare inf->hwaddress.mac to the current dhcp response
>>>> packet.
>>> It's not. You return even if packet didn't match.
>> Hi,
>>
>> Oh i see, i forget about the return a few lines beyond.
> Hi,
>
> oh, there seems to be a missing grub_netbuff_free here as well, pls
> check if this is ok.
The patch is still incorrect. Namely the problem is with netbuff_pull
being called in every loop. I've committed a fixed version.
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature