[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New command testspeed
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH] New command testspeed |
|
Date: |
Sun, 29 Apr 2012 22:28:52 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 |
On 29.04.2012 22:23, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 29.04.2012 22:09, Bean wrote:
>> Hi,
>>
>> Pls check out this one.
> In terms of decreasing code duplication it doesn't improve at all. The
> prefix-chosing code needs to be put into a separate function which would
> be used by both instances.
E.g.
#define GRUB_HUMAN_SIZE_MAX_LEN sizeof ("XXXXXXXXXXXXXXXXXXXX TiB")
void grub_huma_size_make_size (char *res, grub_disk_addr_t sz);
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature