Re: [PATCH] Increase flexibility of kernel naming, allow non-versioned kernels.

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 29.04.2012 06:46, Mike Gilbert wrote:
> I am relaying a patch by Robin Johnson, one of the core infrastructure
> staff at Gentoo Linux. In the process of building some Gentoo servers
> utilizing GRUB 2, he has made some changes to 10_linux that should make
> grub-mkconfig "out of the box" for additional users.
>
> I did a little work to clean up the indentation and wrote a proper
> changelog. Credit should go to him.
>
> Here is his description:
>
> Increase flexibility of kernel naming, allow non-versioned kernels.
> The block that tried to find the kernels was getting unweidly long, as
> was not
> easily customizable by users or distributors. Refactor to introduce a new
> variable, GRUB_KERNEL_GLOB, that allows complete control over the naming
> used
> to search for kernel binaries.
It was well structured and its length is solely due to distros using
multiple names. We can't make it shorter and this patch surely didn't.
Also it looks like it actually degraded compatibility on POSIX systems.
I don't consider that being able to customise the kernel naming is of
any advantage. Saying otherwise is like saying "let's make location of
/etc/passwd customizable". Some objects just have to be named as given.
I don't see any advantage to renaming kernels, especially given that you
can change versionstring as you see fit.
> Add 'bzImage' to the list of default names to support more distribution
> naming
> variants.
>
> Adjust the default set of globs to look for unversioned kernels before
> versioned kernels, to find symlinked kernel names.
Additionally empty version would probably result in some quirks not
addressed in this patch.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature