Re: Device instability, gettext and default

[Andreas Vogel]

Am 03.03.2012 14:37, schrieb Vladimir 'φ-coder/phcoder' Serbinenko:
> === modified file 'grub-core/commands/menuentry.c'
> --- grub-core/commands/menuentry.c    2012-02-26 16:28:05 +0000
> +++ grub-core/commands/menuentry.c    2012-03-03 12:11:30 +0000
> @@ -36,6 +36,8 @@
>       N_("Keyboard key to quickly boot this entry."), N_("KEYBOARD_KEY"), 
> ARG_TYPE_STRING},
>      {"source", 4, 0,
>       N_("Use STRING as menu entry body."), N_("STRING"), ARG_TYPE_STRING},
> +    {"id", 1, GRUB_ARG_OPTION_REPEATABLE,
> +     N_("Menu entry identifier."), N_("STRING"), ARG_TYPE_STRING},
>      {0, 0, 0, 0, 0, 0}
>    };

1) After bzr-pulling your latest changes and reviewing that source
again, i noticed that you are using GRUB_ARG_OPTION_REPEATABLE for the
new id option but you are not handling multiple ids (as far as i can see).

2) Why do you refuse to allow short options for all of the menuentry
options? Any special reason?

3) Wouldn't it be a good chance to use my patch which uses an anonymous
enum for indexing the options array?