|
From: | Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: | Re: Freeze on 27 February |
Date: | Mon, 27 Feb 2012 19:20:12 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 |
On 27.02.2012 07:01, Richard Laager wrote:
I've rewritten this code. I've also committed most of your changes except the one adding the tree scanning when we already have oneOn Mon, 2012-02-27 at 01:00 +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:The allowed characters are: [a-zA-Z0-9_.: -]This isn't a good enough argument. One could purposedly create a pool named `rm -rf /*` even though it's incorrect.By "allowed characters", I meant that the normal ZFS stack will not permit you to create a pool using characters outside that range. That said, I haven't verified that the kernel itself refuses to create/load such a pool.
The patch I proposed is no worse than the code that's already in GRUB. Given the impending freeze and the fact that I'm on vacation, can you apply it and I'll come back to this issue later? I've CC'ed myself so I don't forget.
-- Regards Vladimir 'φ-coder/phcoder' Serbinenko
[Prev in Thread] | Current Thread | [Next in Thread] |