grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Freeze on 27 February


From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: Freeze on 27 February
Date: Mon, 27 Feb 2012 19:17:37 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0

On 27.02.2012 07:58, Richard Laager wrote:
On Thu, 2012-02-23 at 07:34 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
zfs-poolname-spaces.patch
...
@@ -420,6 +419,9 @@
         if (sscanf (sep, "%s %s", entry.fstype, entry.device) != 2)
        continue;

+      unescape (entry.fstype);
+      unescape (entry.device);
+
You need to increase the size of storage for these fields.
On second look... why?
It turns out that the sizes were already increased. Just that PATH_MAX refers to unescaped length, original can be substantially larger.
  The unescape() function modifies the string in
place, and it changes multi-character escape sequences into single
unescaped characters. I don't understand how this would change the size
requirement.



--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko




reply via email to

[Prev in Thread] Current Thread [Next in Thread]