grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Lists and aliasing (Re: Freeze on 27 February)


From: Lennart Sorensen
Subject: Re: Lists and aliasing (Re: Freeze on 27 February)
Date: Wed, 22 Feb 2012 10:34:18 -0500
User-agent: Mutt/1.5.20 (2009-06-14)

On Tue, Feb 21, 2012 at 09:29:08PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko 
wrote:
> diff --exclude Makefile.util.am --exclude Makefile.in --exclude grub.info 
> --exclude configure --exclude aclocal.m4 --exclude '*autom4te.cache*' -ur 
> mainline/configure.ac mainline-mod/configure.ac
> --- mainline/configure.ac     2012-02-21 14:29:15.000000000 +0100
> +++ mainline-mod/configure.ac 2012-02-21 20:18:57.327763779 +0100
> @@ -377,7 +377,7 @@
>  LIBS=""
>  
>  # debug flags.
> -WARN_FLAGS="-Wall -W -Wshadow -Wold-style-declaration -Wold-style-definition 
> -Wpointer-arith -Wundef -Wextra -Waddress -Warray-bounds -Wattributes 
> -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered 
> -Wcomment -Wcoverage-mismatch -Wdeprecated -Wdeprecated-declarations 
> -Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels 
> -Wfloat-equal -Wformat-contains-nul -Wformat-extra-args -Wformat-security 
> -Wformat-y2k -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration 
> -Wimplicit-int -Winit-self -Wint-to-pointer-cast -Winvalid-pch 
> -Wunsafe-loop-optimizations -Wlogical-op -Wmain -Wmissing-braces 
> -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn 
> -Wmudflap -Wmultichar -Wnonnull -Woverflow -Wpacked-bitfield-compat 
> -Wparentheses -Wpointer-arith -Wpointer-to-int-cast -Wreturn-type 
> -Wsequence-point -Wshadow -Wsign-compare -Wstack-protector -Wstrict-aliasing 
> -Wswitch -Wsync-nand -Wtrigraphs  -Wtype-limits -Wundef -Wuninitialized 
> -Wunknown-pragmas -Wunreachable-code -Wunused -Wunused-function 
> -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value  
> -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings 
> -Wmissing-declarations -Wmissing-parameter-type  -Wmissing-prototypes 
> -Wnested-externs -Wstrict-prototypes -Wpointer-sign"
> +WARN_FLAGS="-Wall -W -Wshadow -Wold-style-declaration -Wold-style-definition 
> -Wpointer-arith -Wundef -Wextra -Waddress -Warray-bounds -Wattributes 
> -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered 
> -Wcomment -Wcoverage-mismatch -Wdeprecated -Wdeprecated-declarations 
> -Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels 
> -Wfloat-equal -Wformat-contains-nul -Wformat-extra-args -Wformat-security 
> -Wformat-y2k -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration 
> -Wimplicit-int -Winit-self -Wint-to-pointer-cast -Winvalid-pch 
> -Wunsafe-loop-optimizations -Wlogical-op -Wmain -Wmissing-braces 
> -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn 
> -Wmudflap -Wmultichar -Wnonnull -Woverflow -Wpacked-bitfield-compat 
> -Wparentheses -Wpointer-arith -Wpointer-to-int-cast -Wreturn-type 
> -Wsequence-point -Wshadow -Wsign-compare -Wstrict-aliasing -Wswitch 
> -Wsync-nand -Wtrigraphs  -Wtype-limits -Wundef -Wuninitialized 
> -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label 
> -Wunused-parameter -Wunused-result -Wunused-value  -Wunused-variable 
> -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings 
> -Wmissing-declarations -Wmissing-parameter-type  -Wmissing-prototypes 
> -Wnested-externs -Wstrict-prototypes -Wpointer-sign"
>  HOST_CFLAGS="$HOST_CFLAGS $WARN_FLAGS"
>  TARGET_CFLAGS="$TARGET_CFLAGS $WARN_FLAGS -g -Wredundant-decls 
> -Wmissing-prototypes"
>  TARGET_CCASFLAGS="$TARGET_CCASFLAGS -g"
> diff --exclude Makefile.util.am --exclude Makefile.in --exclude grub.info 
> --exclude configure --exclude aclocal.m4 --exclude '*autom4te.cache*' -ur 
> mainline/grub-core/commands/testload.c 
> mainline-mod/grub-core/commands/testload.c
> --- mainline/grub-core/commands/testload.c    2012-02-08 00:13:14.000000000 
> +0100
> +++ mainline-mod/grub-core/commands/testload.c        2012-02-21 
> 20:57:08.003762787 +0100
> @@ -100,7 +100,10 @@
>      {
>        char sector[GRUB_DISK_SECTOR_SIZE];
>  
> -      pos -= GRUB_DISK_SECTOR_SIZE;
> +      if (pos >= GRUB_DISK_SECTOR_SIZE)
> +     pos -= GRUB_DISK_SECTOR_SIZE;
[snip]

OK, still seeing things like:

gcc-4.4 -DHAVE_CONFIG_H -I. -I../..  -Wall -W -I./include -DGRUB_UTIL=1 
-DGRUB_LIBDIR=\"/usr/lib/grub\" -DLOCALEDIR=\"/usr/share/locale\"  
-DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1 
-DGRUB_FILE=\"grub-core/disk/ldm.c\" -I. -I../.. -I. -I../.. -I../../include 
-I./include  -I./grub-core/gnulib -I../../grub-core/gnulib                -g 
-Wall -O2 -Wall -W -Wshadow -Wold-style-declaration -Wold-style-definition 
-Wpointer-arith -Wundef -Wextra -Waddress -Warray-bounds -Wattributes 
-Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered -Wcomment 
-Wcoverage-mismatch -Wdeprecated -Wdeprecated-declarations 
-Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels -Wfloat-equal 
-Wformat-contains-nul -Wformat-extra-args -Wformat-security -Wformat-y2k 
-Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int 
-Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wunsafe-loop-optimizations 
-Wlogical-op -Wmain -Wmissing-braces -Wmissing-field-initializers 
-Wmissing-format-attribute -Wmissing-noreturn -Wmudflap -Wmultichar -Wnonnull 
-Woverflow -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith 
-Wpointer-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare 
-Wstrict-aliasing -Wswitch -Wsync-nand -Wtrigraphs  -Wtype-limits -Wundef 
-Wuninitialized -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label 
-Wunused-parameter -Wunused-result -Wunused-value  -Wunused-variable 
-Wvariadic-macros -Wvolatile-register-var -Wwrite-strings 
-Wmissing-declarations -Wmissing-parameter-type  -Wmissing-prototypes 
-Wnested-externs -Wstrict-prototypes -Wpointer-sign -Werror  -Wno-undef 
-Wno-sign-compare -Wno-unused -Wno-unused-parameter -Wno-redundant-decls 
-Wno-unreachable-code -Wno-conversion -Wno-old-style-definition                
-c -o grub-core/disk/libgrubkern_a-ldm.o `test -f 'grub-core/disk/ldm.c' || 
echo '../../'`grub-core/disk/ldm.c
cc1: warnings being treated as errors
../../grub-core/disk/ldm.c: In function 'grub_util_get_ldm':
../../grub-core/disk/ldm.c:834: error: 'res' may be used uninitialized in this 
function

I will do a build with werror disabled to grab any remaining warnings.

-- 
Len Sorensen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]