Re: [MERGE] Add a --disable-zfs configure flag.

[Mike Gilbert]

On 02/04/2012 03:06 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 04.02.2012 20:56, Mike Gilbert wrote:
>> I happen to have the ZFS libraries installed on my machine, but I don't
>> want my boot loader to use them. It seems to be broken for me at the
>> moment in any case.
>>
>> I'm new to bazaar and this is my first submission to this mailing list,
>> so please let me know if I've done something incorrectly.
> It's not maintainable to disable a feature every time we meet an issue
> with a part of code.

There is no maintenance burden here, just a one-time change to
configure.ac. The code already has the proper #ifdefs and whatnot.

Also, this goes beyond my own build issues. Having configure auto-detect
libraries with no way to manually override it creates an "automagic
dependency", which we hate over at Gentoo Linux. The following link has
a great explanation.

http://www.gentoo.org/proj/en/qa/automagic.xml

> Could you please detail on your issues?

I'm getting the following build failure:

gcc -DHAVE_CONFIG_H -I.   -Wall -W -I./include -DGRUB_UTIL=1
-DGRUB_LIBDIR=\"/usr/local/lib/grub\"
-DLOCALEDIR=\"/usr/local/share/locale\"  -DGRUB_MACHINE_PCBIOS=1
-DGRUB_MACHINE=I386_PC -DGRUB_TARGET_CPU_I386=1
-DGRUB_FILE=\"util/getroot.c\" -I. -I. -I. -I. -I./include -I./include
-I./grub-core/gnulib -I./grub-core/gnulib                  -Wno-undef
-Wno-sign-compare -Wno-unused -Wno-unused-parameter               -MT
util/libgrubkern_a-getroot.o -MD -MP -MF
util/.deps-util/libgrubkern_a-getroot.Tpo -c -o
util/libgrubkern_a-getroot.o `test -f 'util/getroot.c' || echo
'./'`util/getroot.c
util/getroot.c:2384:1: error: unknown type name 'libzfs_handle_t'
util/getroot.c: In function 'fini_libzfs':
util/getroot.c:2389:3: warning: implicit declaration of function
'libzfs_fini' [-Wimplicit-function-declaration]
util/getroot.c: At top level:
util/getroot.c:2392:1: error: unknown type name 'libzfs_handle_t'
util/getroot.c: In function 'grub_get_libzfs_handle':
util/getroot.c:2397:7: warning: implicit declaration of function
'libzfs_init' [-Wimplicit-function-declaration]
util/getroot.c:2397:23: warning: assignment makes pointer from integer
without a cast [enabled by default]

I have the libzfs headers in /usr/include/libzfs, which is where the ZFS
on Linux build system puts them. My best guess is that it isn't finding
libzfs.h, but I haven't really dug in.

signature.asc
Description: OpenPGP digital signature