[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New command to check NT's hibernation state

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: New command to check NT's hibernation state
Date: Sat, 17 Dec 2011 12:39:41 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20111114 Icedove/3.1.16

   /* Try to open 'hiberfil.sys' */
   hibr_file = grub_file_open (hibr_file_path);
   if (!hibr_file)
       if (grub_errno == GRUB_ERR_FILE_NOT_FOUND)
grub_error (GRUB_ERR_FILE_NOT_FOUND, N_("'hiberfil.sys' not found"));
This overriding is unnecessary. FS code already provides this message
This was intentional: the default message ('file not found') is not particularly helpful in this case since the command's description nowhere mentions what file it's looking for (let alone that any file is needed for it to function). I've updated this section to pop the first error off the stack to eliminate the duplication (and added
a descriptive comment).
This means that your copy of GRUB is old. Newer ones do have the descriptive message. And even if it wasn't the case it's something to be fixed in FS code, not by replacing error message here.

Vladimir 'φ-coder/phcoder' Serbinenko

reply via email to

[Prev in Thread] Current Thread [Next in Thread]