grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Fix for warnings when making in po


From: Seth Goldberg
Subject: Fix for warnings when making in po
Date: Tue, 15 Nov 2011 12:19:18 -0800 (PST)
User-agent: Alpine 2.00 (GSO 1167 2008-08-23)

Hi,

 I've been seeing these for a while:

/usr/bin/xgettext: warning: The option --msgid-bugs-address was not specified.
                            If you are using a `Makevars' file, please specify
                            the MSGID_BUGS_ADDRESS variable there; otherwise 
please
                            specify an --msgid-bugs-address command line option.
grub.po: warning: Charset "CHARSET" is not a portable encoding name.
                  Message conversion to user's charset might not work.


The problem is that make is spawning separate subshells for different blocks
of shell script, and the msgid_bugs_address env var is lost after the first.
This fixes that:

=== modified file 'po/Makefile.in.in'
--- po/Makefile.in.in   2010-12-21 12:49:29 +0000
+++ po/Makefile.in.in   2011-11-15 20:12:06 +0000
@@ -165,7 +165,7 @@
              --package-version='@VERSION@' \
              --msgid-bugs-address="$$msgid_bugs_address" \
            ;; \
-       esac
+       esac; \
        case `$(XGETTEXT) --version | sed 1q | sed -e 's,^[^0-9]*,,'` in \
'' | 0.[0-9] | 0.[0-9].* | 0.1[0-5] | 0.1[0-5].* | 0.16 | 0.16.[0-1]*) \
            $(XGETTEXT) --default-domain=$(DOMAIN) --directory=$(top_srcdir) \
@@ -187,7 +187,7 @@
              --join-existing --language=Shell \
              --keyword=gettext_quoted --keyword=gettext_printf \
            ;; \
-       esac
+       esac; \
        test ! -f $(DOMAIN).po || { \
          sed -f grub.d.sed < $(DOMAIN).po > $(DOMAIN).1po && \
          mv $(DOMAIN).1po $(DOMAIN).po; \





reply via email to

[Prev in Thread] Current Thread [Next in Thread]