[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Disable unsupported grub_util_get_fd_sectors in geli on
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH 2/2] Disable unsupported grub_util_get_fd_sectors in geli on MINGW32 |
|
Date: |
Thu, 22 Sep 2011 00:08:12 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13 |
On 21.09.2011 23:29, Mario Limonciello wrote:
> +#if !defined(__MINGW32__)
> s = grub_util_get_fd_sectors (fd, &log_secsize);
> grub_util_fd_seek (fd, dev, (s << log_secsize) - 512);
> +#endif
This would make GRUB behave erratically if this code is ever reached
which is always a bad thing. While doing something like
#if defined (GRUB_UTIL) && ! defined (__MINGW32__)
on whole function is a cheap and functionality-reducing way to port,
correct way is to add a windows equivalent of this call (getting
disk/file size)
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature