[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Disable functionality that doesn't work on MINGW32
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH 0/2] Disable functionality that doesn't work on MINGW32 |
Date: |
Thu, 22 Sep 2011 00:02:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13 |
On 21.09.2011 23:29, Mario Limonciello wrote:
> The following two patches are for disabling some specifics that will
> not work on MINGW32.
>
> Vladimir explicitly expressed disinterest in going the route of #undef
> GRUB_UTIL, but it seems to be the most appropriate method in the first
> patch to me because MINGW32 does not support ttys and won't ever.
>
GRUB_UTIL means that we run under an OS and use it. While Windows is a
low-quality one, it's still one, so GRUB_UTIL must be defined. Correct
way to dial with this issue is to add a windows equivalent of this code
(requesting password from user).
> The second patch just matches other code, since there is no
> grub_util_get_fd_sectors defined on MINGW32. This will at least get
> the file compiling with potentially broken functionality, which I see
> as an improvement over not compiling and no functionality.
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature