Re: Merge request: more-mingw32-support

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 07.09.2011 03:38, Mario Limonciello wrote:
> Hello,
>
> I've assembled a small collection of patches that get mingw support a
> little bit futher along, particularly for grub-setup.  With these
> patches i'm able to build a MinGW target by:
>
> # ./autogetn.sh
> # CC=i586-mingw32msvc-gcc ./configure --host=i586-mingw32msvc
> # make grub-setup.exe
>
> The collection is at this URL :
> https://code.launchpad.net/~superm1/grub/more-mingw32-support
> <https://code.launchpad.net/%7Esuperm1/grub/more-mingw32-support>
> And can be merged from lp:~superm1/grub/more-mingw32-support
>
> Specifically here are links for the individual patches:
> http://bazaar.launchpad.net/~superm1/grub/more-mingw32-support/revision/3423
> http://bazaar.launchpad.net/~superm1/grub/more-mingw32-support/revision/3424
> http://bazaar.launchpad.net/~superm1/grub/more-mingw32-support/revision/3425
> http://bazaar.launchpad.net/~superm1/grub/more-mingw32-support/revision/3426
> http://bazaar.launchpad.net/~superm1/grub/more-mingw32-support/revision/3427
>
> If requested, i'll be happy to resend all of these as individual
> patches to the mailing list as well.
>
Yes. We need to have the patches go through ML for the record. Some of
your patches are no-brain merge but others are no-brain reject (like
using #undef GRUB_UTIL which is wrong in idea (let's disable the code we
don't seem to use) (it will result in frequent breakage) and
implementation (undefing something completely unrelated)).
Please send one patch per mail
> Thanks,
>
> -- 
> *Mario Limonciello*
> Linux Engineer
> *Dell*| OS Engineering
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature