grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Grub2 EFI: Image loading from USB takes too long


From: Bean
Subject: Re: Grub2 EFI: Image loading from USB takes too long
Date: Tue, 26 Apr 2011 11:03:58 +0800

Hi,

It's not decided by fs driver, it's configured by a flag in
grub_file_open, which is passed to the disk driver. There is only a
few places where we can expect large file, such as linux/initrd
command. And in this case, caching is useless since we only use the
data once and caching would only flush out useful data unnecessarily.
By setting a flag to indicate direct read is required, we can optimize
access for such situation while keeping the cache for others. This is
similar to the pass through flag for linux/windows.

> Which is an example of bad design. Rather than improving the existing
> function to do both caching and unbroken read (like in my 4096 branch)
> you have 2 functions and force upper layers to do the tradeoffs and care
> about matters which should be abstracted and invisible to them.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]