Re: [PATCH] Re: ACPI halt failures in tests

[Colin Watson]

On Thu, Dec 23, 2010 at 01:07:15AM -0800, Jordan Uggla wrote:
> I think it's more likely a race condition of sorts; it's assumed that
> the code that prints "ACPI shutdown failed" is unreachable when ACPI
> shutdown succeeds, since the code comes after shutdown has been
> requested. Part of the reason I think this is that the symptom I've
> been seeing is just "A" or "AC" being printed, which means that the
> shutdown is not synchronous (it's happening in the middle of a
> printf). Since in real hardware I can't see this being much of a
> problem (except maybe causing false alarms for people who log serial
> output), and it would be good to have some type of message on the
> screen when ACPI shutdown does fail, I don't think this should be just
> a dprintf. Instead I think that the unit test's grub.cfg should
> disable serial terminal just before running halt as a work around.

Thanks!  This does indeed make more sense than my patch.  I've gone
ahead and committed it, with trivial tweaks (including fixing the
spelling of your name in ChangeLog ;-) ).

-- 
Colin Watson                                       address@hidden