[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] segfault in grub-probe when spare or faulty disks are found
From: |
Martin Schitter |
Subject: |
Re: [PATCH] segfault in grub-probe when spare or faulty disks are found |
Date: |
Wed, 29 Sep 2010 14:16:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100913 Icedove/3.0.7 |
Am 2010-09-28 22:24, schrieb Vladimir 'φ-coder/phcoder' Serbinenko:
I didn't respond to the patch because it's not correct: it only
propagates the restriction instead of removing it. Thanks for reporting
the issue. I'll fix it tomorrow (hopefully)
yes, there are more consequent ways to solve the problem.
my simple patch doesn't distinguish between all the special cases:
index == 0xffff: spare disk,
index == 0xfffe: faulty disk
index out of range (>= GRUB_RAID_MAX_DEVICES).
it makes a very simple test and ignores all affected devices in any
case. isn't that enough to prevent the segmentation fault?
it would be nice, if you could find a better workaround.