grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Documentation update for recent GRUB script changes


From: Colin Watson
Subject: Re: [PATCH] Documentation update for recent GRUB script changes
Date: Mon, 6 Sep 2010 23:01:11 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Sun, Sep 05, 2010 at 03:16:06PM +0530, BVK Chaitanya wrote:
> Updated patch with documentation for "return" command.

I assume you've checked that all the detailed semantics from bash(1)
regarding return values and the like hold in GRUB script as well.

> +removed from the input stream and effectively address@hidden a
> +backslash-newline pair within a variable name is not handled properly, so
> +use this feature with some care.}.).  A double quote may be quoted within

The punctuation is tricky here.  I think that should be:

+use this feature with some care.}).  A double quote may be quoted within

> +``top-level'' loop) is resumed.  The return value is 0 unless @code{n} is

I think perhaps @dfn{top-level} - ``...'' may not produce nice-looking
quotes in all output formats.

> +The positional parameters from @code{n}+1 ... are renamed to @code{$1}... .

Use @dots{} for ellipses.

Otherwise this looks fine - go ahead.  Thanks!

-- 
Colin Watson                                       address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]