[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug report: PXE blocksize
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: Bug report: PXE blocksize |
Date: |
Mon, 30 Aug 2010 02:06:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Icedove/3.0.6 |
On 08/27/2010 05:57 PM, Turner, Ian wrote:
> Hello list,
>
> There seem to be a couple of problems with this variable:
>
> 1. The variable name in the code is pxe_blksize, whereas the info file
> references net_pxe_blksize.
>
Fixed. Thanks
> 2. Changing the blocksize from within a config file which is itself sourced
> from TFTP breaks the transfer of the remainder of that file, because
> grub_pxe_read() references the grub_pxe_blksize variable at each packet.
>
> Issue #2 can be resolved just by changing the grub_pxe_read() reference to
> grub_pxe_blksize to reference data->block_size instead.
>
I don't see where you mean. The only reference to pxe_blksize I see in
pxefs_read is following:
o.packet_size = grub_pxe_blksize;
grub_pxe_call (GRUB_PXENV_TFTP_OPEN, &o);
Which is called only when reopening file. Could you retry pulling? Now
newreloc is merged into mainline so you can just pull mainline.
> This is in the newreloc branch.
>
> Cheers,
>
> --Ian
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature