Re: Bug#593467: grub-pc: add support for root ext2/xfs on GNU/kFreeBSD

[Aurelien Jarno]

On Wed, Aug 18, 2010 at 05:46:23PM +0200, Aurelien Jarno wrote:
> On Wed, Aug 18, 2010 at 03:16:03PM +0100, Colin Watson wrote:
> > On Wed, Aug 18, 2010 at 03:07:57PM +0200, Aurelien Jarno wrote:
> > > Since GNU/kFreeBSD switch to grub as the default bootloader, it is 
> > > almost possible to use an ext2 or xfs root filesystem. While there
> > > is not a lot of interest in doing that, the patch to do it is quite
> > > small. Could you please apply it in the next upload?
> > 
> > Sending upstream first.  Does this require copyright assignment?
> > 
> 
> As I have been told on IRC, XFS support is only read-only, so there is
> no point on adding root support for it yet. ext2 support works in read
> write mode, and has been tested as root. Please find an updated patch 
> below.

And here is the same patch with a changelog entry as requested on IRC.

2010-08-20  Aurelien Jarno  <address@hidden>

        * util/grub.d/10_kfreebsd.in: Translate ext2 into ext2fs.
        (kfreebsd_entry): On ext2 root, load `ext2fs.ko'

--- grub2-1.98+20100804.orig/util/grub.d/10_kfreebsd.in
+++ grub2-1.98+20100804/util/grub.d/10_kfreebsd.in
@@ -75,6 +75,14 @@
   fi
 
   case "${kfreebsd_fs}" in
+    ext2fs)
+      test -e "${module_dir}/ext2fs.ko"
+
+      printf '%s\n' "${prepare_module_dir_cache}"
+      cat << EOF
+       kfreebsd_module_elf     ${module_dir_rel}/ext2fs.ko
+EOF
+    ;;
     zfs)
       test -e "${module_dir}/opensolaris.ko"
       test -e "${module_dir}/zfs.ko"
@@ -121,6 +129,7 @@
 
   case ${GRUB_FS} in
     ufs1 | ufs2)        kfreebsd_fs=ufs ;;
+    ext2)               kfreebsd_fs=ext2fs ;;
     *)                  kfreebsd_fs=${GRUB_FS} ;;
   esac
 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net