Re: [PATCH] Bash completion script for grub util commands

[Colin Watson]

On Wed, Aug 11, 2010 at 01:42:58PM +0200, Yves Blusseau wrote:
>  ChangeLog.completion.bash                        |    3 
>  Makefile.in                                      |    4 
>  util/integration/completion/grub-completion.bash |  450 
> ++++++++++++++++++++++
>  3 files changed, 457 insertions(+), 0 deletions(-)
>  create mode 100644 ChangeLog.completion.bash
>  create mode 100644 util/integration/completion/grub-completion.bash

20:59 <phcoder> cjwatson: is it convenient to install bash_completion scripts 
in non-bash package?

At least from this point of view, sure, I don't see a problem.  I think
perhaps util/integration/completion/grub-completion.bash is
unnecessarily deep nesting in the source tree though; creating two
levels of subdirectory at once seems a bit much.  If it were me I'd
probably put it in util/bash-completion.d/grub.  (Also, I think the
bikeshed should be pink.)

> diff --git a/ChangeLog.completion.bash b/ChangeLog.completion.bash
> new file mode 100644
> index 0000000..8b1fea9
> --- /dev/null
> +++ b/ChangeLog.completion.bash
> @@ -0,0 +1,3 @@
> +2010-08-11  Yves Blusseau  <address@hidden>
> +
> +     * util/integration/completion/grub-completion.bash: New script

I assume that this will in fact go in ChangeLog when committed to trunk.

-- 
Colin Watson                                       address@hidden