|
From: | Seth Goldberg |
Subject: | Re: [PATCH] Enable `grub-probe -t device' resolution on ZFS |
Date: | Fri, 30 Jul 2010 14:08:24 -0700 (PDT) |
User-agent: | Alpine 2.00 (GSO 1167 2008-08-23) |
Hi,I saw your commit of these changes. Why are you delivering a libzfs.h and libnvpair.h? I think GRUB should be using the headers that are installed on the systems, otherwise you run the risk of linking against a library whose prototypes may not match their implementation (libnvpair is less of a concern, since those are unlikely to change).
--S Quoting Robert Millan, who wrote the following on Fri, 30 Jul 2010:
2010/7/29, Seth Goldberg <address@hidden>:This code will not handle a mirrored root pool. See the Solaris implementation of vdev_get_physpaths() and zpool_get_config_physpath().Thanks for the pointer. I avoid reading libzfs source, but looking at the dump from nvlist_print(), the problem seems obvious. I'll adjust it to support a second layer. _______________________________________________ Grub-devel mailing list address@hidden http://lists.gnu.org/mailman/listinfo/grub-devel
[Prev in Thread] | Current Thread | [Next in Thread] |