Re: [Patch] strip disk->name of partition suffix in grub_disk_open

[Grégoire Sutre]

On 07/20/2010 03:52 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:

> Which functions concatenate disk->name with anything else? It looks like
> disk->name is with partitions by design.

In several places, the (full) grub partition name is obtained by
concatenating disk->name with the result of grub_partition_get_name.

If I read the code correctly, this is what is done in:

function iterate_partition, file normal/completion.c.
function grub_device_iterate, file kern/device.c
function grub_efidisk_get_device_name, file disk/efi/efidisk.c

and I did the same in

function grub_util_biosdisk_get_grub_dev, file kern/emu/hostdisk.c

and more recently, for warnings/dprintfs, in

function grub_partition_check_containment, file kern/partition.c
function bsdlabel_partition_map_iterate, file partmap/bsdlabel.c


Assuming that the above are correct and that disk->name is correctly
set in grub_disk_open (e.g. hd0,msdos3,bsd7), then shouldn't
disk->partition have a NULL parent (which is not the case right now)?

Grégoire