grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix grub-probe partition naming on FreeBSD


From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] Fix grub-probe partition naming on FreeBSD
Date: Thu, 01 Jul 2010 22:57:00 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4

On 06/13/2010 12:48 PM, Colin Watson wrote:
> The following patch is aimed at fixing this Debian bug:
>
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585068
>
>
> +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> +static int
> +device_is_wholedisk (const char *os_dev)
> +{
> +  const char *p;
> +
> +  if (strncmp (os_dev, "/dev/", 5) != 0)
> +    return 0;
> +
> +  for (p = os_dev + 5; *p; ++p)
>   
Please use sizeof. Other than that please go ahead.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]