[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] USB UHCI portstatus correction
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [Patch] USB UHCI portstatus correction |
|
Date: |
Fri, 25 Jun 2010 21:45:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4 |
On 06/20/2010 11:23 AM, Aleš Nesrsta wrote:
> Hi,
>
> I found some mistake in uhci.c in grub_uhci_portstatus when enable=0.
> There is proposal of correction.
>
> Without correction portstatus reported false timeout when enable=0
> because it is waiting for reset to be done but none is performed...
>
>
This patch seems to change much more that you say. In particular
enable=0 is a request to disable port and you seem to always enable it.
This is likely to break other code.
> Best regards
> Ales
>
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature