Re: Bug in multiboot_mbi2.c

[Seth Goldberg]

 BTW, while we're at it, we can remove the redundant 
tag->common.framebuffer_type assignment :).

 --S

Quoting Seth Goldberg, who wrote the following on Mon, 21 Jun 2010:

>  The code that constructs the framebuffer info has a nasty bug where the 
> field position and mask size for red are set to the GREEN values:
>
>      tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB;
>      tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB;
> -->   tag->framebuffer_red_field_position = mode_info.green_field_pos;
> -->   tag->framebuffer_red_mask_size = mode_info.green_mask_size;
>      tag->framebuffer_green_field_position = mode_info.green_field_pos;
>      tag->framebuffer_green_mask_size = mode_info.green_mask_size;
>      tag->framebuffer_blue_field_position = mode_info.blue_field_pos;
>      tag->framebuffer_blue_mask_size = mode_info.blue_mask_size;
>
>
> --S
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel