[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Migrations to xorriso
From: |
Thomas Schmitt |
Subject: |
Re: Migrations to xorriso |
Date: |
Thu, 20 May 2010 11:30:33 +0200 |
Hi,
attached is an updated patch to summarize my
current proposal for grub-mkrescue.
My reply to mails of Vladimir and Seth seems
still stuck in eggs.gnu.org. (At least that
was the culprit last time.)
The current proposal follows Vladimir's idea:
> I'm thinking to allow passing arbitrary options to xorriso by just
> putting it on command line.
It would give the user control over option
-no-pad (saves 300 kB) and allow to switch from
mkisofs emulation to the native xorriso command
set.
-----------------------------------------------
New ponderings:
-----------------------------------------------
The following statement in the proposed help text
is due to the way how extra arguments are handled
via variable $source:
"Be aware that source paths must be single words.
Quotation marks will not work."
If grub-mkrescue options would be prescribed to
precede any source paths or xorriso options, then
we could use a while loop, shift and "$@",
rather than a for loop and ${source}.
while test -n "$1"; do
case "$1" in
...
--modules=*)
modules=`echo "$1" | sed 's/--modules=//'`
shift
;;
...
*)
break ;;
esac
done
...
${xorriso} ... "$@"
This would be safe for nearly all filenames.
(Newlines are still not allowed then.)
Question is whether support for apple-ish file
names is worth a change in the rules for
grub-mkrescue.
Have a nice day :)
Thomas
--
GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01
grub-mkrescue.in.ts2.patch
Description: Text Data
- Re: Migrations to xorriso, (continued)
- Re: Migrations to xorriso, Thomas Schmitt, 2010/05/19
- Re: Migrations to xorriso, Colin Watson, 2010/05/19
- Re: Migrations to xorriso, Isaac Dupree, 2010/05/19
- Re: Migrations to xorriso, Thomas Schmitt, 2010/05/19
- Re: Migrations to xorriso, Vladimir 'φ-coder/phcoder' Serbinenko, 2010/05/19
- Re: Migrations to xorriso, Seth Goldberg, 2010/05/19
Re: Migrations to xorriso, Vladimir 'φ-coder/phcoder' Serbinenko, 2010/05/19
Re: Migrations to xorriso,
Thomas Schmitt <=