[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] [bug #26237] multiple problems with usb devices
From: |
Aleš Nesrsta |
Subject: |
Re: [Patch] [bug #26237] multiple problems with usb devices |
Date: |
Thu, 08 Apr 2010 23:27:18 +0200 |
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> > I am not so far oriented in such kind of development, so I am asking:
> > Will You correct my patch yourself (as maintainer of code) or should I
> > prepare new corrected code and related patch? And against which version
> > - I noted that in meantime new official version was released...
> >
> Normally we ask contributors to clean their patches themselves. But
> given the great importance of your changes I'll cleaned them up myself.
> You can find the partially cleaned version in attachment.
> I recommend using bzr trunk but USB code hasn't changed since few months
> due to lack of dev time
Thanks.
> > Did You tests on OHCI/UHCI and what was the result?
> > What HW are You using for testing - some real PC or qemu ?
> >
> I have a computer with integrated UHCI and OHCI+EHCI PCI card.
> Testing on it showed that your patch fixed UHCI but had no effect on
> OHCI. with OHCI grub_ohci_detect_dev always sees status = 0. I see the
> similar behaviour when testing usb on grub-yeeloong-firmware (but not
> when chinloaded by pmon). I guess some register initialisation is missing.
I will test the usb.diff soon and than I try to more study EHCI
specification. On my PC is OHCI detected properly but I have very old
machine Toshiba Satellite 2140CDS (i586 at 450MHz) with one OHCI only
interface. I.e. it looks like problem appears only on combined OHCI-EHCI
interfaces. I have also plan to debug GRUB2 USB support on other, newer
machine with OHCI-EHCI interfaces.
I will inform You there if I will discover something interesting...
Best regards
Ales