Check for device type (block/character) in grub-setup?

[Grégoire Sutre]

Hi,

I'm wondering why there is no check for device type (block/character) in 
grub-setup.c whereas the function probe() in grub-probe.c exits with 
error if the device is not of the expected type. Shouldn't there be a 
similar check in grub-setup?

Currently, on NetBSD (with in-progress patches), grub-setup fails with 
an `out of disk error' on a block device as the detected disk size is 0, 
whereas grub-probe exits gracefully with an error message telling that 
the input device is not a character device.  I guess that a similar 
behavior could be observed on FreeBSD, but I can't actually test this.

Thanks,

Grégoire