[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] macrofy (multiterm branch)
From: |
Robert Millan |
Subject: |
Re: [PATCH] macrofy (multiterm branch) |
Date: |
Fri, 1 Jan 2010 13:11:21 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Thu, Dec 31, 2009 at 07:31:56PM +0100, Carles Pina i Estany wrote:
>
> Hi,
>
> Find an attached patch to macrofy pos >> 8 and pos & 0xff in multiter.
> In my opinion should be macrofied, it's more clear.
Agreed.
> === modified file 'include/grub/term.h'
> --- include/grub/term.h 2009-12-25 02:37:20 +0000
> +++ include/grub/term.h 2009-12-30 18:17:55 +0000
> @@ -32,6 +32,8 @@
> #define GRUB_TERM_ESC '\e'
> #define GRUB_TERM_TAB '\t'
> #define GRUB_TERM_BACKSPACE 8
> +#define GETX(XY) (XY >> 8)
> +#define GETY(XY) (XY & 0xff)
It should have GRUB_ prefix. Otherwise it can go in.
--
Robert Millan
"Be the change you want to see in the world" -- Gandhi
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] macrofy (multiterm branch),
Robert Millan <=